Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove send_onchain #1125

Merged
merged 2 commits into from
Nov 22, 2024
Merged

Remove send_onchain #1125

merged 2 commits into from
Nov 22, 2024

Conversation

JssDWt
Copy link
Contributor

@JssDWt JssDWt commented Nov 15, 2024

The send_onchain function was deprecated since SDK version 0.3.6. It
has been replaced with pay_onchain. Removed deprecated functions:

  • send_onchain, has replacement pay_onchain
  • max_reverse_swap_amount has replacement onchain_payment_limits
  • on_progress_reverse_swaps has replacement
    in_progress_onchain_payments

@JssDWt JssDWt force-pushed the jssdwt-remove_send_onchain branch from 1780a0b to ed7ce56 Compare November 15, 2024 13:44
Copy link
Collaborator

@dangeross dangeross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

The `send_onchain` function was deprecated since SDK version 0.3.6. It
has been replaced with `pay_onchain`. Removed deprecated functions:
- `send_onchain`, has replacement `pay_onchain`
- `max_reverse_swap_amount` has replacement `onchain_payment_limits`
- `on_progress_reverse_swaps` has replacement
  `in_progress_onchain_payments`
@JssDWt JssDWt force-pushed the jssdwt-remove_send_onchain branch from ed7ce56 to 46f7ad9 Compare November 22, 2024 11:50
@JssDWt JssDWt merged commit 46f7ad9 into main Nov 22, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants